Welcome, Guest. Please login or register.

Pages: [1]
Print
Author Topic: Fixing the patch submission process  (Read 4392 times)
mvBarracuda
Admin
Community member

Posts: 1308



View Profile Email
« on: November 30, 2010, 06:33:57 AM »

This one is pretty much a follow up to the "switch to git proposal" thread. While we can address the shortcomings of missing local branching support of SVN by using git-svn, we still need to figure out how we could improve the patch submission process for contributors.

In theory, the process is pretty much straight forward at this point. You create a new ticket at trac, attach the patch and send it in. Unfortunately about 90% of the valid tickets sent in by users who don't have a PARPG account yet had been blocked in the past. This was caused by a rather restrictively configured Trac anti spam plugin. We had to resort to this restrictive configuration as we had massive problems with spam in the past.

I had a closer look at the trac plugins that codesion.com offers, and it seems that our account had an anti spam plugin activated, while a newer version of it actually resides in trac core now. Therefore, I've deactivated the older plugin and created a test ticket with an attached patch and it went through just fine: http://parpg-trac.cvsdude.com/parpg/ticket/274

So we would need your help to test if the reconfigured spam plugin actually blocks the spam but let's the ham through. Feel free to create testing tickets at trac and let us know if they got through or were blocked. Furthermore we'll have to monitor trac closely in the next couple of days to see if reconfiguring the spam plugin actually manages to block valid spam.

To create a test ticket, simply make sure that you're not logged into trac and create a new ticket. Try to come up with some reasonable title and description for the ticket so it sounds somewhat realistic.

In case trac manages to properly block spam but let's valid tickets / patches through, we would have pretty much resolved our patch submission problems. While it's surely still slightly more complicated than the patch process for git, getting trac properly working for anonymous patches would ease our work to a great deal nevertheless.
« Last Edit: November 30, 2010, 06:38:50 AM by mvBarracuda » Logged
aspidites
Community member

Posts: 29


View Profile Email
« Reply #1 on: November 30, 2010, 11:35:48 PM »

id be game if you can gegt the spam filter tp not hate me. may be a good idea for devs to add a changes file to version control. that way, when a patch is created, changes made will be annotated as well
Logged
mvBarracuda
Admin
Community member

Posts: 1308



View Profile Email
« Reply #2 on: December 01, 2010, 03:48:08 AM »

Unfortunately we had about two dozens of spam tickets and comments in the last 24 hours so we decided to take a closer look again.

We fiddled around with the trac plugins and it seems that spam is now correctly blocked by the captcha plugin we use. How it works: if you either use "anonymous" as reporter name or add a hyperlink in the ticket or the comment, this will trigger the anti spam addon and you'll have to solve a captcha to get the ticket/comment through.

While captchas can be annoying, this is prolly the best way to block automated spam with minimal annoyances for legit ticket reporters.

EDIT: We've played around with submitting tickets and it seems that valid tickets actually get through without having to solve a captcha. There can be false positives, but the system should work pretty well (hopefully). Anyway, please let us know in this thread if your tickets got through right away or if you had to solve the captcha. There is some additional room for tweaking the anti spam addon if necessary.
« Last Edit: December 01, 2010, 03:57:55 AM by mvBarracuda » Logged
zenbitz
Community member

Posts: 1164



View Profile
« Reply #3 on: December 01, 2010, 08:04:25 PM »

The capcha should only occur on account creation and NOT when you are logged in, correct?
Logged

We are not denying them an ending...
We are denying them a DISNEY ending - Icelus
mvBarracuda
Admin
Community member

Posts: 1308



View Profile Email
« Reply #4 on: December 02, 2010, 04:36:26 AM »

Captcha's will only be triggered in case the user is not logged into his account, right. Even if he's not logged into it, the ticket still has a good chance to get through if neither regex (based on the BadContent article), akismet nor typepad categorize the content as suspicious. In this case and only in this case, the captcha will be shown.

Logged in users will be trusted by default even if they seem to submit highly suspicious tickets. Considering that we have full control over who gets a Trac account, that is a reasonable policy IMHO.
Logged
Pages: [1]
Print
Jump to: