Latest Inventory Code

[Bretzel13]

Here is the latest Inventory code. Just extract it to <FIFE>/clients/ and run inventory.py.

The zip was too large to attach, so download from here:
http://www.mediafire.com/?sharekey=233de89b95ee15a7d2db6fb9a8902bda

I welcome any feedback or suggestions!

Thanks,
Bretzel

[Bretzel13]

The very latest inventory code with fancy images! (Big thanks to Sirren for the images)
Download Link: http://rapidshare.com/files/231220912/inventory.zip.html

Bretzel

[maximinus]

Hi Bretzel

Do I need to patch the FIFE code again? I saw on the IRC logs that you seem to have resolved that problem, so I hope not 

Anyhow, I at work right now, I will take a good look and comment back when I get home tonight.

[Bretzel13]

Nope, you don't need to patch FIFE anymore. I've got everything now self-contained within my code.

There was one more update to the code (this should be the last one until people have checked it over). It now contains all of Sirren's images for the inventory.

Download link: http://rapidshare.com/files/231395350/inventory.zip.html

[maximinus]

Hi Bretzel

I took a look at the code. Big positive point first: it works!

Small annoying points:

• Since you used a mix of tabs and spaces, indentation was wrong on my editor
• It lacks any comments in the code!
• You have to pretty accurate on placement (probably more a PyChan thing)

I've fiddled around with inventory.py so you can see what I mean (also adjusted the logic a little), look at this file to compare the difference: http://rapidshare.com/files/231600929/inventory.py.html. Any chance you could take a look and add some simple comments so I can understand it better?

For everybody else, and maybe for barra's Monday update, here's a piccy (slightly edited to reduce size, but it shows the important stuff):

[Zimble]

Tried it out, worked and looks like an inventory.
Sorry, couldn't say more because I have absolutely no clue, whats going on in the code (don't know anything about python).

Being a programmer myself I hate the situation when you've coded hours and hours and people come and look at it an are like "Uh... nice - what does it do?"

So... just want to appreciate your work, Bretzel.

[Bretzel13]

Thanks Zimble, I know what you mean

Maximinus,

Indentation/Spaces issue:
Probably because I tried out one editor, didn't like it, and switched back to old faithful Emacs.

Comments:
Will add them.

The exact placement:
You're right that is PyChan. There's nothing I can do about that short of modifying PyChan, but then we get into that big discussion we had earlier about how to implement the changes. You know what I'm talking about

Changes in logic:
That's a much shorter way of doing it, thanks!

Thanks for the feedback,
Bretzel

[maximinus]

Indentation/Spaces issue:
Probably because I tried out one editor, didn't like it, and switched back to old faithful Emacs.

Emacs has a text editor inside it? 

As for modifying Pychan, well you know what I though of that (bad), but now I can see where you are coming from 

[Bretzel13]

Emacs is primarily a text editor, it just has a bunch of extra goodies in it. It takes a while to learn the shortcuts, but once you do it is incredibly easy to edit files.

Since we are using pydoc for our comments, is there a specific way you want me to do them?

[maximinus]

Emacs is primarily a text editor, it just has a bunch of extra goodies in it. It takes a while to learn the shortcuts, but once you do it is incredibly easy to edit files.

Only joking. Emacs is great!

Since we are using pydoc for our comments, is there a specific way you want me to do them?

Not really. I mean, you can go study epydoc and come back with something stunning, but really we just need some simple one line comments scattered around telling us how the code works, otherwise maintenance will be nightmare.

[Bretzel13]

Alright, I should have something done by tonight.

Bretzel

[mvBarracuda]

Feel free to attach the latest patch to your ticket at trac Bretzel :-) Anonymous ticket creation and changes are activated again.

[Bretzel13]

Alright the latest code is at the trac ticket. (http://parpg-trac.cvsdude.com/parpg/ticket/62)

Be sure to download inventory.2.zip

Bretzel

[maximinus]

Cool, I'll check it out tonight (that's probably tomorrow morning for you)

[zenbitz]

Since you used a mix of tabs and spaces, indentation was wrong on my editor

BURN HIM!